fix: revert type re-exports from ORM indexes, restore migrate-client entry point#892
Merged
pyramation merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
…entry point The 'types' commit (d0c5a9f) added export * from './types' to all generated ORM index files and deleted sdk/migrate-client/src/index.ts. The subsequent revert only fixed the codegen template but not the already-generated SDK files. This commit: - Removes export * from './types' from all 9 generated ORM index files - Removes export type { ConnectionResult, PageInfo } from './select-types' - Restores sdk/migrate-client/src/index.ts (re-exports from ./migrate)
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous revert of commit
d0c5a9f74("types") only fixed the codegen template but missed two things:export * from './types'andexport type { ConnectionResult, PageInfo } from './select-types'— causing ~80+ TS2308 name collision errors at build timesdk/migrate-client/src/index.tswas deleted in that same commit and never restored — causingtscto fail with "No inputs were found in config file"This PR removes the leftover
export * from './types'lines from all 9 generated ORM index files (constructive-cli,constructive-react,migrate-client) and restores the deletedmigrate-cliententry point.Review & Testing Checklist for Human
pnpm buildfrom repo root — should complete with zero errors (previously failed onsdk/migrate-clientand any package importing from ORM barrels)graphql/codegen/src/core/codegen/orm/client-generator.ts) does NOT containexport * from './types'— this was fixed in a prior revert and is not part of this diff, but confirms future regenerations will be correctsdk/migrate-client/src/index.tscontent (export * from './migrate') matches what existed befored0c5a9f74Notes
export * from './types'approach was fundamentally broken:input-types.tscontains 2000+ generated types that collide with names inselect-types.tsand shared hooks types. This cannot be fixed with explicit re-exports at scale.types.tsbarrel file still exists in each ORM directory and remains importable directly — it's just not re-exported through the main ORM index to avoid collisions.Link to Devin session: https://app.devin.ai/sessions/ce1b2dafd42341bea5d7793b0c05ba6c
Requested by: @pyramation